mrproliu commented on code in PR #209:
URL: https://github.com/apache/skywalking-rover/pull/209#discussion_r3479868219
##########
bpf/include/protocol_analyzer.h:
##########
@@ -178,7 +178,7 @@ static __inline __u32 infer_http2_message(const char* buf,
size_t count) {
return CONNECTION_MESSAGE_TYPE_UNKNOWN;
}
-static __inline __u32 analyze_protocol(char *buf, __u32 count, __u8
*protocol_ref) {
+static __noinline __u32 analyze_protocol(char *buf, __u32 count, __u8
*protocol_ref) {
Review Comment:
Add the include `api.h` to fix it.
##########
bpf/include/socket_reader.h:
##########
@@ -30,7 +30,7 @@ struct {
__uint(max_entries, 1);
} socket_buffer_reader_map SEC(".maps");
-static __inline struct socket_buffer_reader_t* read_socket_data(char* buf,
struct iovec *iovec, __u32 bytes_count) {
+static __noinline struct socket_buffer_reader_t* read_socket_data(char* buf,
struct iovec *iovec, __u32 bytes_count) {
Review Comment:
Add the include `api.h` to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
