wu-sheng opened a new pull request, #81:
URL: https://github.com/apache/skywalking-horizon-ui/pull/81
## Why
A broad correctness + polish pass on the UI. A codebase-wide **comment
audit** (per the project's comment principles) fed a 32-finding **gap review**;
an adversarial verification pass confirmed the real bugs and killed the
false-positives. Booting fresh against the demo OAP to validate caught a
**release-blocking BFF boot crash**. Two operator-requested features land
alongside.
## What
**Hygiene**
- Codebase-wide comment audit — strip ~331 non-earning comments, shorten
verbose blocks, and restore 8 over-removed gotchas (mesh/k8s service-id
matching, bundled probe-path, THREE.js live-object sync, …).
**Bug fixes (gap review, adversarially verified — 5 false-positives
dropped)**
- 🔴 **Critical:** BFF boot crash — `/api/ebpf/network/processes` had no
`ROUTE_POLICY` entry, so the RBAC guard threw on boot. Masked by a stale dev
process; type-check was green the whole time.
- `useNetworkProcesses` loading-stuck on modal close; Escape on two topology
dropdowns; Logs + Browser-Errors filter cascade-clear on service switch; Logs
page reset; Browser-Errors source-map clear on service switch;
`NewEBPFTaskModal` full reset; `DensityHistogram` label-case.
**Features**
- **Browser Errors manual-fire** — mirrors Logs: stage conditions into an
applied snapshot, fetch only on **Run query**, reset to the prompt on service
switch.
- Profiling create flow — consistent, honest gating; network task picks its
instance in-dialog and validates it has rover-monitored processes before Create.
- **Colored value-mapping cards** — a `format: 'enum'` card renders matched
values/labels as colored status chips (`ok`/`warn`/`err`/`info`/`neutral`),
editable in the layer-dashboard admin's value-map editor. The K8s **Node
Status** card now shows the node's active conditions (`Ready` green,
`*Pressure`/`NetworkUnavailable` amber-red) instead of a raw `1`. Also fixes
the widget schema silently stripping
`format`/`valueMap`/`valueColors`/`labelTopN`.
**Docs + i18n**
- Profiling create-gating + Logs/Browser-Errors manual-fire docs; 18 i18n
keys × 8 locales for the new profiling strings.
## Validation
- type-check 0, lint clean, both builds, license check, **278 unit tests
pass** (162 BFF + 116 UI), i18n complete across all 8 locales.
- **Live-validated headless against the demo OAP**: Browser Errors
manual-fire gate (placeholder → Run query → fetch), the network-processes route
(`{processes:[], reachable:true}`), and the K8s Node Status colored chips
(`Ready` green).
- The `LayerDashboardsAdmin` XL-file decomposition is intentionally deferred
to its own focused PR (scoped + noted in-code).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
