songzhendong commented on PR #139: URL: https://github.com/apache/skywalking-nodejs/pull/139#issuecomment-4818795712
Thank you for taking the time to review the code. Round-2 fixes are in **one commit** on `feature/nodejs-grpc-v1-runtime-metrics`: ### Round-2 (blocking / high) 1. **Late RPC callbacks after shutdown** — `GRPCChannelManager` cached in `prepare()`; async paths use `reportGrpcError()` (no `findService(GRPCChannelManager)!` in callbacks). 2. **False DISCONNECT on `reportError()`** — if grpc-js channel is still connected, re-notify `CONNECTED`; otherwise `DISCONNECT`. ### Same commit (self-review hardening + alignment) | Item | Change | |------|--------| | `shutdown()` | `notify(DISCONNECT)` before clearing listeners | | Lifecycle | `closed` guards on timers / flush / report paths | | Trace stream | `stream.end()` try/catch; EventEmitter `off` before `on` | | Meter stream | `stream.end()` try/catch | | Heartbeat | Java-style alternation: `counter % 10 == 0` → `reportInstanceProperties`, else `keepAlive` only (tick still 20s) | | Polish | optional listener typing; timer `unref()` style | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
