songzhendong commented on PR #13930: URL: https://github.com/apache/skywalking/pull/13930#issuecomment-4829054643
Thanks for the review — Blockers 1. test/e2e-v2/script/env — duplicate keys Fixed: removed the duplicate SW_AGENT_NODEJS_COMMIT / SW_AGENT_GO_COMMIT lines. Each key appears once: SW_AGENT_NODEJS_COMMIT=36df516… SW_AGENT_GO_COMMIT=19a9fa9… (master’s go-agent #250 pin) 2. docs/menu.yml — Telegraf Metrics path Fixed: restored path: "/en/setup/backend/telegraf-receiver" under Telegraf Metrics. Minor 3. dashboards-nodejs-runtime.md — env var names Fixed: the table now leads with canonical SW_AGENT_NODEJS_RUNTIME_METRICS_*; SW_AGENT_RUNTIME_METRICS_*, SW_AGENT_NVM_METRICS_*, and SW_AGENT_NVM_JVM_* are documented together as deprecated aliases. 4. docs/en/debugging/config_dump.md — sample order Fixed: meterAnalyzerActiveFiles in the doc sample now matches application.yml / the E2E config-dump.yml assertion (including ruby-runtime, php-runtime, with nodejs-runtime appended at the end). Validation Changes are validated on our fork https://github.com/songzhendong/skywalking/actions/runs/28343981058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
