Copilot commented on code in PR #63:
URL:
https://github.com/apache/skywalking-banyandb-helm/pull/63#discussion_r3489710291
##########
chart/values.yaml:
##########
@@ -1056,6 +1056,17 @@ cluster:
ktmEnabled: true
## @param cluster.fodc.agent.config.pollClusterStateInterval Interval
for polling cluster state from Proxy (poll-cluster-state-interval flag)
pollClusterStateInterval: 30s
+ ## Panic/crash diagnostics collection. Shares an emptyDir between the
banyand
+ ## container (writes panic.json) and the fodc-agent (reads & reports
it).
Review Comment:
The comment truncates the component name (“banyand”) which reads like a
typo/incomplete sentence and may confuse users skimming values.yaml.
##########
chart/templates/standalone_statefulset.yaml:
##########
@@ -257,6 +273,9 @@ spec:
- --max-metrics-memory-usage-percentage={{
.Values.cluster.fodc.agent.config.ktmEnabled | ternary 20 10 }}
- --heartbeat-interval={{
.Values.cluster.fodc.agent.config.heartbeatInterval }}
- --reconnect-interval={{
.Values.cluster.fodc.agent.config.reconnectInterval }}
+ {{- if .Values.cluster.fodc.agent.config.crashCollection.enabled }}
Review Comment:
The FODC agent args include a trailing "\\" at the end of the --proxy-addr
argument, which will be passed literally to the container and may break address
parsing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
