This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git
The following commit(s) were added to refs/heads/master by this push:
new 70487a5 disable the lifecycle metrics collector if the container has
disabled (#64)
70487a5 is described below
commit 70487a59e772976fec5e0acf2b635fcd92f3f90b
Author: mrproliu <[email protected]>
AuthorDate: Tue Jun 30 08:35:40 2026 +0800
disable the lifecycle metrics collector if the container has disabled (#64)
* disable the lifecycle metrics collector if the container has disabled
* Potential fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI
<[email protected]>
Co-authored-by: Gao Hongtao <[email protected]>
---
CHANGES.md | 1 +
chart/templates/cluster_data_statefulset.yaml | 6 ++++++
2 files changed, 7 insertions(+)
diff --git a/CHANGES.md b/CHANGES.md
index 9616a2a..0c2eb0c 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -10,6 +10,7 @@ Release Notes.
- Remove etcd support (breaking change).
If upgrading, remove `etcd-client.*` and `cluster.*.tls.etcdSecretName`
from your values overrides.
+- Disable the lifecycle metrics collector when the lifecycle sidecar container
is disabled.
- Enable FODC panic/crash diagnostics collection by default.
Configure via
`cluster.fodc.agent.config.crashCollection.{enabled,dir,maxArtifacts,diagnosisMemoryPercent}`.
diff --git a/chart/templates/cluster_data_statefulset.yaml
b/chart/templates/cluster_data_statefulset.yaml
index e4718a7..d4c2778 100644
--- a/chart/templates/cluster_data_statefulset.yaml
+++ b/chart/templates/cluster_data_statefulset.yaml
@@ -322,9 +322,15 @@ spec:
args:
- --proxy-addr={{ template "banyandb.fullname" $
}}-fodc-proxy-grpc:{{ $.Values.cluster.fodc.proxy.grpcSvc.port }}
- --pod-name=$(POD_NAME)
+ {{- if $roleConfig.lifecycleSidecar.enabled }}
- --container-names=data,lifecycle
- --poll-metrics-ports=2121,17915
- --cluster-state-ports=17912,17914
+ {{- else }}
+ - --container-names=data
+ - --poll-metrics-ports=2121
+ - --cluster-state-ports=17912
+ {{- end }}
- --lifecycle-port=17912
{{- if $roleConfig.lifecycleSidecar.enabled }}
- --lifecycle-report-dir={{ default "/tmp/lifecycle-reports"
$roleConfig.lifecycleSidecar.reportDir }}
