abnobdoss commented on issue #13950: URL: https://github.com/apache/skywalking/issues/13950#issuecomment-5009147787
@tisonkun Agreed, symlinking LICENSE/NOTICE into each crate directory is the fix, and that's what iceberg-rust and arrow-rs do. The issue is that as Rust workspaces grow new crates, the discipline tends to slip (see the table below). iceberg-rust is considering hand-rolling their own CI check for this, which got me wondering whether it'd make sense as part of skywalking-eyes instead. Not trying to overstate this. Just exploring whether it's a reasonable addition to skywalking-eyes so Apache-licensed Rust projects can get this out of the box. If it doesn't feel like the right fit or is too big of an addition, totally respect that. This is purely an inquiry, and I'm happy to contribute if the community thinks it makes sense and is open to guiding me on how you'd prefer it added. @wu-sheng Here's a live example. apache/paimon-rust uses `skywalking-eyes/[email protected]` in CI and passes clean, but none of its published crates have LICENSE or NOTICE files in their directories. For contrast, apache/datafusion has symlinked `LICENSE.txt`/`NOTICE.txt` in most crates so they package correctly, but `datafusion-cli/` is missing both and header CI still passes. I checked 9 Apache Rust workspace repos: | Repo | Published crates with LICENSE/NOTICE | Header tool | File-presence check | |---|---|---|---| | iceberg-rust | 15/15 | skywalking-eyes | none | | avro-rs | 4/4 | HawkEye | none | | datafusion | 35/38 | HawkEye | none | | arrow-rs | 30/35 | Apache RAT | none | | iggy | 0/6 | HawkEye | none | | hudi-rs | 0/6 | skywalking-eyes | none | | paimon-rust | 0/5 | skywalking-eyes | none | | horaedb | 0/12 | HawkEye | none | | ballista | 0/7 | Apache RAT | none | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
