innerpeacez commented on a change in pull request #21: modify role to
clusterrole
URL:
https://github.com/apache/skywalking-kubernetes/pull/21#discussion_r337037259
##########
File path: helm-chart/helm3/6.4.0/skywalking/templates/oap-deployment.yaml
##########
@@ -91,6 +91,10 @@ spec:
fieldPath: metadata.uid
- name: SW_STORAGE
value: elasticsearch
+ {{- if .Values.oap.envoy.als.enabled }}
Review comment:
In order to enable envoy als, there is a clusterrole privilege, and when it
is not enabled, only role privilege
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
