xuzhiguang commented on PR #816: URL: https://github.com/apache/skywalking-java/pull/816#issuecomment-5126518759
I reconsidered the implementation. I’ll use an exact match for java.util.concurrent.ThreadPoolExecutor and won’t enhance its subclasses for invokeAll/invokeAny. Subclasses that inherit these methods will still go through the enhanced ThreadPoolExecutor implementation, which avoids duplicate nested interception. I’ll also switch the interceptor to InstanceMethodsAroundInterceptorV2 and use MethodInvocationContext to pass the span creation state and span reference between beforeMethod, afterMethod, and handleMethodException. This avoids both ThreadLocal and recomputing the decision from the arguments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
