dmsolr commented on a change in pull request #3717: fix deficient code,
"/socket.io/" http segment declare
URL: https://github.com/apache/skywalking/pull/3717#discussion_r339914184
##########
File path:
test/plugin/scenarios/netty-socketio-scenario/src/main/webapp/WEB-INF/web.xml
##########
@@ -22,6 +22,10 @@
version="3.1">
<display-name>skywalking-netty-socketio-scenario</display-name>
+ <listener>
+
<listener-class>org.apache.skywalking.apm.testcase.netty.socketio.ContextListener</listener-class>
+ </listener>
+
Review comment:
I think this will cause unstable. If possible, move it to health-check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
