wu-sheng commented on a change in pull request #3748: Remove two max size 500
limit.
URL: https://github.com/apache/skywalking/pull/3748#discussion_r340962864
##########
File path:
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/cache/NetworkAddressInventoryCacheEsDAO.java
##########
@@ -84,7 +84,7 @@ public NetworkAddressInventoryCacheEsDAO(ElasticSearchClient
client) {
try {
SearchSourceBuilder searchSourceBuilder = new
SearchSourceBuilder();
searchSourceBuilder.query(QueryBuilders.rangeQuery(NetworkAddressInventory.LAST_UPDATE_TIME).gte(lastUpdateTime));
- searchSourceBuilder.size(500);
+ searchSourceBuilder.size(Integer.MAX_VALUE);
Review comment:
And every load has this condition
```java
List<NetworkAddressInventory> addressInventories =
addressInventoryCacheDAO.loadLastUpdate(System.currentTimeMillis() - 60000);
```
The inventory is being reloaded only the update happens at the last minute.
And timer runs every 10s(static config today)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
