aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin 
& elasticsearch 6.x test scenario
URL: https://github.com/apache/skywalking/pull/3803#discussion_r344447060
 
 

 ##########
 File path: test/plugin/scenarios/elasticsearch-6.x-scenario/bin/startup.sh
 ##########
 @@ -0,0 +1,23 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+home="$(cd "$(dirname $0)"; pwd)"
+
+java -jar ${agent_opts} -Dskywalking.plugin.elasticsearch.trace_dsl=true 
${home}/../libs/elasticsearch-6.x-scenario.jar &
+
+# user for more time to collect data
+sleep 5
 
 Review comment:
   Sorry, there is a problem with the above explanation. The healthCheck is 
there. In fact, the reason is not that the ES startup time takes a few seconds, 
but because six requests are executed at one time in the test service, six 
segments are generated, and now In the JVM container, the waiting time for 
collection is 5s. Due to insufficient waiting time, the local information will 
result in incomplete collection of information, and the subsequent segments are 
not collected. I can normally collect it by adding a sleep to the wait above. 
And this local test success.  I just tested it, I removed `sleep 5`, and the 
test passed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to