wu-sheng commented on a change in pull request #20: Add ServiceInstanceTopology
& ServiceInstanceNode
URL:
https://github.com/apache/skywalking-query-protocol/pull/20#discussion_r352568390
##########
File path: topology.graphqls
##########
@@ -36,6 +42,26 @@ type Node {
isReal: Boolean!
}
+# Node in ServiceInstanceTopology
+type ServiceInstanceNode {
+ # The global id of each node,
+ # 1. Service id
+ serviceId: ID!
+ # The literal name of the #serviceId.
+ serviceName: String!
+ # The global id of each node,
+ # 1. Instance id
+ instanceId: ID!
+ # The literal name of the #instanceId.
+ instanceName: String!
Review comment:
Should be renamed as `name`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
