wu-sheng commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-562410420 > like my code shown stackDepth is reduced because ContextManager.stopSpan . ContextManager.stopSpan is executed to clean up the context of the current thread When you have the async span, the `#stop` is only reducing the stackDepth as you said. But you still have span ref, right? You could propagate it to any thread, and operate it. The core will wait for you to do real async finish. And the issue you posted is true, I didn't realize it before. I think all similar methods in `#EntrySpan` and `#ExitSpan` should add `setxxxInAsync`(work in `isInAsyncMode==true`) to ignore the `currentMaxDepth` and `stackDepth`. At the same time, `setxxx` should not work in `isInAsyncMode==true`. Make sense? If YES, please submit a new pull request to adjust that. We should add them separately. The changes should begin with `AbstractSpan`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
