wu-sheng commented on a change in pull request #3945: Enhance webflux plugin,
related to Spring Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#discussion_r357620033
##########
File path: test/plugin/scenarios/webflux-scenario/pom.xml
##########
@@ -23,36 +23,85 @@
<groupId>org.apache.skywalking</groupId>
<artifactId>webflux-scenario</artifactId>
- <packaging>pom</packaging>
+ <packaging>jar</packaging>
<version>5.0.0</version>
- <modules>
- <module>webflux-projectA-scenario</module>
- <module>webflux-projectB-scenario</module>
- <module>webflux-dist</module>
- </modules>
-
- <name>skywalking-webflux-scenario</name>
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
- <test.framework.version>2.0.0.RELEASE</test.framework.version>
+ <compiler.version>1.8</compiler.version>
+
+ <test.framework>webflux-scenario</test.framework>
+ <test.framework.version>2.1.1.RELEASE</test.framework.version>
<docker.image.version>${test.framework.version}</docker.image.version>
</properties>
+ <name>webflux-scenario</name>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.springframework.boot</groupId>
+ <artifactId>spring-boot-starter-webflux</artifactId>
+ <version>${test.framework.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>com.squareup.okhttp3</groupId>
+ <artifactId>okhttp</artifactId>
+ <version>3.0.0</version>
+ </dependency>
+ </dependencies>
+
<build>
<finalName>webflux-scenario</finalName>
<plugins>
<plugin>
- <groupId>org.apache.maven.plugins</groupId>
+ <groupId>org.springframework.boot</groupId>
+ <artifactId>spring-boot-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <goals>
+ <goal>repackage</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.6.0</version>
<configuration>
- <source>1.8</source>
- <target>1.8</target>
+ <source>${compiler.version}</source>
+ <target>${compiler.version}</target>
<encoding>${project.build.sourceEncoding}</encoding>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-assembly-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>assemble</id>
+ <phase>package</phase>
+ <goals>
+ <goal>single</goal>
+ </goals>
+ <configuration>
+ <descriptors>
+
<descriptor>src/main/assembly/assembly.xml</descriptor>
+ </descriptors>
+ <outputDirectory>./target/</outputDirectory>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
</plugins>
</build>
+ <pluginRepositories>
+ <pluginRepository>
+ <id>spring-snapshots</id>
+ <url>http://repo.spring.io/snapshot</url>
+ </pluginRepository>
+ <pluginRepository>
+ <id>spring-milestones</id>
+ <url>http://repo.spring.io/milestone</url>
+ </pluginRepository>
+ </pluginRepositories>
Review comment:
These repos should not exist, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
