wu-sheng commented on issue #4133: provide config stream processor
URL: https://github.com/apache/skywalking/pull/4133#issuecomment-569160177
 
 
   > monitoring tasks are stored in the inventory here, I suppose the tasks are 
created by users in the web UI right? So why they should be deleted after a 
so-called TTL? Does the users expect this? Is it designed for so?
   
   Monitoring should be set by UI or GraphQL. But it isn't inventory, that is 
why we create a new type of streaming process. I think the point of deleting is 
the thread dump will be saved as a kind of record, similar to the segment. So 
even we don't set up TTL, it will miss all related thread dump data.
   I agree to support TTL.
   
   @mrproliu A reminder to you, as TTL setup based on time bucket, this field 
should be set based on task expected finish time, rather than config time. 
Because you need to avoid the task has been deleted before the task starts.
   
   Also, I notice, this task entity is not time series, why? Deleting is a big 
payload for the ES, I would recommend setup the time series for this too.
   
   ___
   
   ## Request rename
   `Config` is a very widely used concept. In the streaming process, a mode 
called config is very strange and not clear. I want to propose the processor 
name, `noneStreamingProcessor`. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to