wu-sheng commented on a change in pull request #4043: Add es7 support to docker
URL: https://github.com/apache/skywalking/pull/4043#discussion_r363066060
 
 

 ##########
 File path: docs/en/guides/How-to-build.md
 ##########
 @@ -51,18 +51,7 @@ or
 ### Build docker images
 We can build docker images of `backend` and `ui` with `Makefile` located in 
root folder.
 
-- Build all docker images
-> make docker.all
-
-- Build oap server docker image
-> make docker.oap
-
-- Build ui docker image
-> make docker.ui
-
-`HUB` and `TAG` variables ares used to setup `REPOSITORY` and `TAG` of a 
docker image. To get
-a oap image with name `bar/oap:foo`, run the following command
-> HUB=bar TAG=foo make docker.oap
+Refer to [Build docker 
image](https://github.com/apache/skywalking/tree/master/docker) for more 
details.
 
 Review comment:
   I know the doc is there. But at here, the doc said, 
   
   > We can build docker images of `backend` and `ui` with `Makefile` located 
in root folder.
   
   There is no tip about reading the doc there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to