Fine0830 commented on issue #14: Add uniqueId for BrowserPerfData URL: https://github.com/apache/skywalking-data-collect-protocol/pull/14#issuecomment-573488379 UUID looks good to me. Yes, can we integrate one query for perf data and error log? ________________________________ From: 吴晟 Wu Sheng <[email protected]> Sent: Monday, January 13, 2020 8:43:42 AM To: apache/skywalking-data-collect-protocol <[email protected]> Cc: Qiuxia Fan <[email protected]>; Mention <[email protected]> Subject: Re: [apache/skywalking-data-collect-protocol] Add uniqueId for BrowserPerfData (#14) @wu-sheng commented on this pull request. ________________________________ In browser/BrowserPerf.proto<https://github.com/apache/skywalking-data-collect-protocol/pull/14#discussion_r365624786>: > @@ -30,17 +30,19 @@ service BrowserPerfService { } message BrowserPerfData { - int32 serviceId = 1; + // UUID + string uniqueId = 1; @Fine0830<https://github.com/Fine0830> Is it OK to generate this unique for client-js report every time? The backend will need this to save the whole report for the UI. Are we going to provide perf data and error log query from UI? ― You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://github.com/apache/skywalking-data-collect-protocol/pull/14?email_source=notifications&email_token=AE7HUZ4B2WQV7E4NZRO7LEDQ5O2L5A5CNFSM4KFYCZL2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCROJRYI#pullrequestreview-341612769>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AE7HUZYQ27ENI2CFRAJ7ACLQ5O2L5ANCNFSM4KFYCZLQ>.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
