mrproliu commented on a change in pull request #4220: [WIP] sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220#discussion_r365901662
########## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java ########## @@ -148,6 +148,31 @@ * If true, skywalking agent will enable profile when user create a new profile task. Otherwise disable profile. */ public static boolean ACTIVE = true; + + /** + * Parallel monitor segment thread count + */ + public static int PARALLELS_THREAD_COUNT = 5; + + /** + * Max monitor segment time(minutes), if current segment monitor time out of limit, then stop it. + */ + public static int MAX_MONITOR_TIME = 10; + + /** + * Max dump thread stack depth + */ + public static int MAX_DUMP_STACK_DEPTH = 500; + + /** + * Snapshot send to backend channel size + */ + public static int SNAPSHOT_SEND_CHANNEL_SIZE = 2; + + /** + * Snapshot send to backend buffer size + */ + public static int SNAPSHOT_SEND_BUFFER_SIZE = 50; Review comment: Change to only one thread to process the profile task. So don't use `DataCarrier` anymore. Change to using `LinkedBlockingQueue` such as sniffer `JVMService`. using buffer size 500. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services