liuhaoXD opened a new issue #4230: potential thread-unsafe problem in 
server-alarm-plugin of oap-server module
URL: https://github.com/apache/skywalking/issues/4230
 
 
   
https://github.com/apache/skywalking/blob/f9cf17be24304bdf4afef423cbb0d5e4925f668f/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java#L232
   
   * `this.moveTo()`at line 234  is thread-unsafe.
   * `minutesBetween` operation should be protected by lock()
   * `if` statement at  line 233 is duplicate with line 240

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to