wu-sheng commented on a change in pull request #4251: Issue about load balance
of gRPC
URL: https://github.com/apache/skywalking/pull/4251#discussion_r367399208
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/StandardChannelBuilder.java
##########
@@ -30,6 +31,10 @@
@Override public ManagedChannelBuilder build(ManagedChannelBuilder
managedChannelBuilder) throws Exception {
return managedChannelBuilder.nameResolverFactory(new
DnsNameResolverProvider())
+ /**
+ * It seems the code above can only work for low gRPC version.
+ */
+ .loadBalancerFactory(RoundRobinLoadBalancerFactory.getInstance())
Review comment:
Also, this doc should be updated as new config added.
https://github.com/apache/skywalking/blob/master/docs/en/setup/service-agent/java-agent/README.md#table-of-agent-configuration-properties
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
