kezhenxu94 commented on a change in pull request #4220: sniffer processing
profile task and report status and snapshot
URL: https://github.com/apache/skywalking/pull/4220#discussion_r367947098
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskExecutionService.java
##########
@@ -151,7 +202,7 @@ public long getLastCommandCreateTime() {
*/
private String checkProfileTaskSuccess(ProfileTask task) {
Review comment:
I prefer to let this method return an `Exception`, maybe
`java.lang.IllegalStateException`, simply return a string is no so semantic,
and you may want to print the stack trace there, since it's a kind of
"exception", in some degree
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
