JohnNiang commented on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+ URL: https://github.com/apache/skywalking/pull/4264#issuecomment-575959138 ###### 1: > the Blank cost more resources, what is the benefit? In many cases, the mothod `org.apache.skywalking.apm.util.StringUtil#isBlank` won't cost more resources. If first character of the string isn't white space, this method returns `false` immediately. Also, we need to check if the method `java.lang.Character#isWhitespace(int)` inside JDK takes time. ###### 2: > allowing these two existing will make the further reviews(of other PRs) confusing. It is hard to tell from all reviewers perspective, which one should be used in which cases. Maybe I should add java documents on two methods. ###### 3: > If there isn't a case, required this, which I think there isn't as this PR didn't add a new feature, but refactor, I hope we don't add these new APIs. Yeah, this PR doesn't contain any `new feature(for skywalking)`, just a refactor with the `new feature of JDK8+`. (BTW, I have never said this PR contains any new feature. : P
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
