kezhenxu94 commented on a change in pull request #4268: merge e2e profile test
project
URL: https://github.com/apache/skywalking/pull/4268#discussion_r368265675
##########
File path: .github/workflows/e2e.yaml
##########
@@ -111,10 +111,10 @@ jobs:
./mvnw -Dcheckstyle.skip -Drat.skip -T2 -Dmaven.compile.fork
-Dmaven.compiler.maxmem=3072 -DskipTests clean install
./mvnw -f test/e2e/pom.xml -pl e2e-base clean install
- name: Profile Tests H2(JDK8)
- run: export E2E_VERSION=jdk8-1.3 && bash -x test/e2e/run.sh
e2e-profile/e2e-profile-h2-test-runner
+ run: export E2E_VERSION=jdk8-1.3 && bash -x test/e2e/run.sh
e2e-profile/e2e-profile-test-runner --env=h2
Review comment:
change the name `env` to `storage` please, we may have other `env` in the
future
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
