wu-sheng commented on a change in pull request #4228: Support Browser protocol
at OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r372359627
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/DefaultScopeDefine.java
##########
@@ -71,16 +71,28 @@
public static final int PROFILE_TASK_LOG = 27;
public static final int PROFILE_TASK_SEGMENT_SNAPSHOT = 28;
+ // browser
+ public static final int BROWSER_PERF_DATA = 40;
+ public static final int BROWSER_PERF_DETAIL = 41;
+ public static final int BROWSER_PAGE_PATH_PERF_DETAIL = 42;
+ public static final int BROWSER_SINGLE_VERSION_PERF_DETAIL = 43;
+ public static final int BROWSER_SINGLE_VERSION_PAGE_PATH_PERF_DETAIL = 44;
+
/**
* Catalog of scope, the metrics processor could use this to group all
generated metrics by oal rt.
*/
public static final String SERVICE_CATALOG_NAME = "SERVICE";
public static final String SERVICE_INSTANCE_CATALOG_NAME =
"SERVICE_INSTANCE";
public static final String ENDPOINT_CATALOG_NAME = "ENDPOINT";
+ public static final String BROWSER_PAGE_PATH_CATALOG_NAME =
"BROWSER_PAGE_PATH";
+ public static final String BROWSER_SINGLE_VERSION_PAGE_PATH_CATALOG_NAME =
"BROWSER_SINGLE_VERSION_PAGE_PATH";
Review comment:
This should be mapping to the service instance, right? Then it should be
named. `BROWSER_APP_SINGLE_VERSION_CATALOG_NAME`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
