JohnNiang commented on issue #4318: Reduce footprint via prototype pattern when tagging spans URL: https://github.com/apache/skywalking/pull/4318#issuecomment-582244844 > Adding a new check rule is to avoid "future users use that method again", so what's your suggestion? We can't avoid using deprecated method, but it's our duty to tell future users that method is deprecated. Just like recent rectifications of invoking rewrited method in deprecated method body, but keep `Deprecated` annotation on the deprecated method. e.g. ```java @Deprecated // Keep this annotation public T deprecatedMethod() { return newMethod(); } public T rewritedMethod() { // Latest codes here... } ``` In a short, Using `Deprecated` api is my suggestion.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
