dmsolr commented on issue #4239: Provide influxdb as a new storage plugin
URL: https://github.com/apache/skywalking/pull/4239#issuecomment-583774959
 
 
   > All `proto` files under `test/e2e` should be removed, instead, add the 
protocol repository as submodule, just like what `e2e-ttl-es` does, otherwise, 
they may be outdated
   > 
   > And I hope you could refactor the `e2e-ttl-es` to something like `e2e-ttl` 
that can be reused for multiple storage types, like `e2e-profile`, we can use 
the same codes to test multiple storage types
   
   I am planning to do it, but it is a low priority in my schedule.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to