wu-sheng commented on a change in pull request #4335: Provide profile analyze
query
URL: https://github.com/apache/skywalking/pull/4335#discussion_r376780713
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/profile/IProfileThreadSnapshotQueryDAO.java
##########
@@ -38,4 +38,17 @@
*/
List<BasicTrace> queryProfiledSegments(String taskId) throws IOException;
+ /**
+ * search snapshots with paging
+ * sort by sequence
+ * @param segmentId profiled segment id
+ * @param start start dump time
+ * @param end end dump time
+ * @param minSequence search sequence start number
+ * @param count page count
+ * @return snapshots
+ * @throws IOException
+ */
+ List<ProfileThreadSnapshotRecord> queryRecordsWithPaging(String segmentId,
long start, long end, int minSequence, int count) throws IOException;
Review comment:
From your codes, `count` is `pageSize`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
