wu-sheng commented on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584024143
 
 
   @Fine0830 Currently, we used to ask `browser_app_error_rate` as a metrics, 
including `error_rate` of single version and page. But in the latest protocol 
change, we support multiple logs for a single one page, 
https://github.com/apache/skywalking-data-collect-protocol/blob/master/browser/BrowserPerf.proto#L34
   
   This protocol can't support to calculate error_rate, because if the 
client-js reports logs for one page in multiple times, the error rate will be 
over 100%. Such as one `collectPerfData` report means 1 PV, but n* 
`collectErrorLogs` reports, the error rate will be n/1.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to