wu-sheng commented on a change in pull request #4327: Tag annotation supports
returned expression
URL: https://github.com/apache/skywalking/pull/4327#discussion_r377433128
##########
File path:
apm-sniffer/apm-toolkit-activation/apm-toolkit-trace-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/trace/TagAnnotationMethodInterceptor.java
##########
@@ -75,6 +74,25 @@ public Object afterMethod(
final Object[] allArguments,
final Class<?>[] argumentsTypes,
final Object ret) {
+ if (ret == null || !ContextManager.isActive()) {
+ ContextManager.stopSpan();
+ return ret;
Review comment:
Move these two lines into the final block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
