JaredTan95 commented on a change in pull request #4344: supprt gRPC alarm hook. URL: https://github.com/apache/skywalking/pull/4344#discussion_r377734123
########## File path: docs/en/setup/backend/backend-alarm.md ########## @@ -113,6 +114,24 @@ Example as following }] ``` +## gRPCHook +The alarm message will send through remote gRPC method by `Protobuf` content type. +The message format with following key information which are defined in `oap-server/server-alarm-plugin/src/main/proto/alarm-hook.proto`. Review comment: I agree with you, but link `alarm-hook.proto` from docs to `source code` dir looks weird. show part of `alarm-hook.proto` and explain `alarm-hook.proto`'s location may be more friendly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
