kezhenxu94 commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r379290950
##########
File path:
oap-server/server-library/library-client/src/main/java/org/apache/skywalking/oap/server/library/client/elasticsearch/ElasticSearchClient.java
##########
@@ -291,6 +291,24 @@ public SearchResponse search(String indexName,
SearchSourceBuilder searchSourceB
return client.search(searchRequest);
}
+ /**
+ * Search results from ES search engine according to various search
conditions,
+ * Note the method is usered for the list of index names is optimized
based on
+ * the scope of startTimeBucket and endTimeBucket
+ * @param indexNameList full index names list base on timebucket scope.
+ * Except for endpoint_inventory network_address_inventory
service_inventory service_instance_inventory
+ * @param searchSourceBuilder Various search query conditions
+ * @return ES search query results
+ * @throws IOException throw IOException
Review comment:
not a good java doc: `throw IOException`, better to describe **WHEN** the
exception is thrown
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
