wu-sheng commented on a change in pull request #4228: Support Browser protocol
at OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r379436664
##########
File path:
test/e2e/e2e-base/src/main/java/org/apache/skywalking/e2e/metrics/MetricsMatcher.java
##########
@@ -64,15 +72,23 @@ public static void verifyMetrics(SimpleQueryClient
queryClient, String metricNam
}
public static void verifyPercentileMetrics(SimpleQueryClient queryClient,
String metricName, String id,
- final LocalDateTime minutesAgo, long retryInterval, Runnable
generateTraffic) throws Exception {
+ final LocalDateTime minutesAgo,
long retryInterval, Runnable generateTraffic) throws Exception {
+ verifyPercentileMetrics(queryClient, metricName, id, minutesAgo,
LocalDateTime.now(ZoneOffset.UTC).plusMinutes(1), retryInterval,
generateTraffic);
Review comment:
Why change it? Please give me more details?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
