wu-sheng commented on a change in pull request #4239: Provide influxdb as a new
storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r380509427
##########
File path:
oap-server/server-storage-plugin/storage-influxdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/influxdb/query/ProfileTaskQuery.java
##########
@@ -95,7 +96,7 @@ public ProfileTask getById(final String id) throws
IOException {
WhereQueryImpl query = select("ID", ProfileTaskRecord.SERVICE_ID,
ProfileTaskRecord.ENDPOINT_NAME,
ProfileTaskRecord.START_TIME,
ProfileTaskRecord.CREATE_TIME,
- ProfileTaskRecord.DURATION,
+ "\"" + ProfileTaskRecord.DURATION +
"\"", // scape, the 'duration' is identifier
Review comment:
Check `ModelInstaller#overrideColumnName`, you could replace the name in the
storage implementation. That is a more elegant way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
