kezhenxu94 commented on a change in pull request #4399: support http api for upstream trace. URL: https://github.com/apache/skywalking/pull/4399#discussion_r384504996
########## File path: oap-server/server-library/library-util/src/main/java/org/apache/skywalking/oap/server/library/util/ProtoBufJsonUtils.java ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.oap.server.library.util; + +import com.google.protobuf.Message; +import com.google.protobuf.util.JsonFormat; +import java.io.IOException; + +public class ProtoBufJsonUtils { + + public static String toJSON(Message sourceMessage) throws IOException { + return JsonFormat.printer().print(sourceMessage); + } + + /** + * Extract data from a JSON String and use them to construct a Protocol Buffers Message. + * + * @param json A JSON data string to parse + * @param targetBuilder A Message builder to use to construct the resulting Message + * @return the constructed Message + * @throws com.google.protobuf.InvalidProtocolBufferException Thrown in case of invalid Message data + */ + public static Message fromJSON(String json, Message.Builder targetBuilder) throws IOException { + JsonFormat.parser() + .usingTypeRegistry(JsonFormat.TypeRegistry.newBuilder() + .add(targetBuilder.getDescriptorForType()) + .build()) + .ignoringUnknownFields() + .merge(json, targetBuilder); + return targetBuilder.build(); Review comment: Seems the returned value is never used, thus `.build()` is unnecessary ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
