hanahmily edited a comment on issue #4514: Add selector property in 
application.yml
URL: https://github.com/apache/skywalking/pull/4514#issuecomment-599170923
 
 
   @kezhenxu94 Good job! Except for some nits.
   
   I prefer to remove unnecessary environment variable converting in entrypoint 
script, so let's just delete them. But to keep `so11y` related segments is a 
good idea because of the link between receiver and telemetry. Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to