aderm commented on a change in pull request #4517: fix elasticsearch-5.x-plugin
when use es6.x TransportClient error
URL: https://github.com/apache/skywalking/pull/4517#discussion_r393391421
##########
File path:
apm-sniffer/apm-sdk-plugin/elasticsearch-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/elasticsearch/v5/define/GenericActionInstrumentation.java
##########
@@ -60,4 +60,10 @@ public String getConstructorInterceptor() {
protected ClassMatch enhanceClass() {
return byHierarchyMatch(new String[]
{"org.elasticsearch.action.GenericAction"});
}
+
+ @Override
+ protected String[] witnessClasses() {
+ return new
String[]{"org.elasticsearch.common.transport.InetSocketTransportAddress"};
Review comment:
recommended to put these and below const string witnesses in one place
better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
