kezhenxu94 commented on a change in pull request #24: Add e2e test with mock collector URL: https://github.com/apache/skywalking-nginx-lua/pull/24#discussion_r393602335
########## File path: test/e2e/e2e-with-mock-collector/docker/conf.d/nginx.conf ########## @@ -0,0 +1,87 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# This nginx.conf is designed and written for local dev environments +# It will use the blocking startup mode and console logging +worker_processes 1; +daemon off; +error_log /dev/stdout debug; + +events { + worker_connections 1024; +} +http { + lua_package_path "/usr/local/skywalking-nginx-lua/lib/skywalking/?.lua;;"; + # Buffer represents the register inform and the queue of the finished segment + lua_shared_dict tracing_buffer 100m; + + # Init is the timer setter and keeper + # Setup an infinite loop timer to do register and trace report. + init_worker_by_lua_block { + local metadata_buffer = ngx.shared.tracing_buffer + + metadata_buffer:set('serviceName', 'e2e-test-with-mock-collector') + -- Instance means the number of Nginx deloyment, does not mean the worker instances Review comment: ```suggestion -- Instance means the number of Nginx deployment, does not mean the worker instances ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
