wu-sheng commented on a change in pull request #4555: Correlation protocol implement URL: https://github.com/apache/skywalking/pull/4555#discussion_r396417992
########## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/IgnoredTracerContext.java ########## @@ -32,30 +32,33 @@ public class IgnoredTracerContext implements AbstractTracerContext { private static final NoopSpan NOOP_SPAN = new NoopSpan(); + private final CorrelationContext correlationContext; + private int stackDepth; public IgnoredTracerContext() { this.stackDepth = 0; + this.correlationContext = new CorrelationContext(); } @Override public void inject(ContextCarrier carrier) { - + carrier.getCorrelationContext().resetFrom(this.correlationContext); Review comment: `inject` is for further propagation, I am confused the implementation here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services