Indifer commented on issue #4517: fix elasticsearch-5.x-plugin when use es6.x 
TransportClient error
URL: https://github.com/apache/skywalking/pull/4517#issuecomment-603626411
 
 
   > These two plugin tests should be enhanced to test your scenarios.
   > 
   > 1. 
https://github.com/apache/skywalking/tree/master/test/plugin/scenarios/elasticsearch-5.x-scenario
   > 2. 
https://github.com/apache/skywalking/tree/master/test/plugin/scenarios/elasticsearch-6.x-scenario
   > 
   > If you haven't familiar with the plugin test, read this doc, 
https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md. 
You should only need to use the ES APIs in the way used to have issue, and 
change the expected data file to prove it is working now.
   
   i have updated

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to