wind2008hxy opened a new pull request #4579: should set the trustStorePath default value empty URL: https://github.com/apache/skywalking/pull/4579 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance - Related issues ___ ### Bug fix - Bug description.  when I set the elastic username & password, but not use ssl connect. when I review the code,they are all right. https://github.com/apache/skywalking/blob/c2e2d4182d5715cce49b6f95670f3fae2f44d0ba/oap-server/server-library/library-client/src/main/java/org/apache/skywalking/oap/server/library/client/elasticsearch/ElasticSearchClient.java#L144 https://github.com/apache/skywalking/blob/c2e2d4182d5715cce49b6f95670f3fae2f44d0ba/oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/StorageModuleElasticsearchProvider.java#L212 - How to fix? the problem is the `application.yml` set the ``` trustStorePath: ${SW_SW_STORAGE_ES_SSL_JKS_PATH:"../es_keystore.jks"} ``` so you should set the trustStorePath default value empty ``` version: '3.3' services: elasticsearch: image: docker.elastic.co/elasticsearch/elasticsearch:6.8.1 container_name: elasticsearch restart: always ports: - 9200:9200 environment: discovery.type: single-node ELASTIC_PASSWORD: test ulimits: memlock: soft: -1 hard: -1 oap: image: apache/skywalking-oap-server:7.0.0-es6 container_name: oap depends_on: - elasticsearch links: - elasticsearch restart: always ports: - 11800:11800 - 12800:12800 environment: SW_STORAGE: elasticsearch SW_NAMESPACE: sk SW_STORAGE_ES_CLUSTER_NODES: elasticsearch:9200 SW_ES_USER: elastic SW_ES_PASSWORD: test SW_SW_STORAGE_ES_SSL_JKS_PATH: "" # this not work # volumes: # - ./application.yml:/skywalking/config/application.yml ui: image: apache/skywalking-ui:7.0.0 container_name: ui depends_on: - oap links: - oap restart: always ports: - 8080:8080 environment: SW_OAP_ADDRESS: oap:12800 ``` Now I modify the `application.yml` set the trustStorePath default value empty. ``` trustStorePath: ${SW_SW_STORAGE_ES_SSL_JKS_PATH:""} ``` It work. ___ ### New feature or improvement - Describe the details and related test reports.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
