wu-sheng commented on a change in pull request #35: Implement correlation
protocol
URL:
https://github.com/apache/skywalking-nginx-lua/pull/35#discussion_r407283978
##########
File path: README.md
##########
@@ -118,7 +120,7 @@ The following APIs are for developers or using this lib
out of the Nginx case.
## Nginx APIs
- **startTimer**,
`require("client"):startBackendTimer("http://127.0.0.1:8080";)`. Start the
backend timer. This timer register the metadata and report traces to the
backend.
-- **start**, `require("tracer"):start("upstream service")`. Begin the tracing
before the upstream begin.
+- **start**, `require("tracer"):start("upstream service", correlation)`. Begin
the tracing before the upstream begin. The custom data (table type) can be
passed in the second parameter, and then you can correlate the data to the
downstream service.
Review comment:
```suggestion
- **start**, `require("tracer"):start("upstream service", correlation)`.
Begin the tracing before the upstream begin. The custom data (table type) can
be injected as the second parameter, and then they will be propagated to the
downstream service.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
