arugal commented on a change in pull request #4748: URL: https://github.com/apache/skywalking/pull/4748#discussion_r420901652
########## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/oal/rt/OALDefine.java ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.skywalking.oap.server.core.oal.rt; + +import lombok.Getter; + +import static java.util.Objects.requireNonNull; + +/** + * Define multiple OAL configuration + */ +@Getter +public enum OALDefine { Review comment: Is that right ? ```java @Getter public abstract class OALDefine { OALDefine(final String configFile, final String sourcePackage, final String dynamicMetricsClassPackage, final String dynamicMetricsBuilderClassPackage, final String dynamicDispatcherClassPackage) { this.configFile = requireNonNull(configFile); this.sourcePackage = requireNonNull(sourcePackage); this.dynamicMetricsClassPackage = requireNonNull(dynamicMetricsClassPackage); this.dynamicMetricsBuilderClassPackage = requireNonNull(dynamicMetricsBuilderClassPackage); this.dynamicDispatcherClassPackage = requireNonNull(dynamicDispatcherClassPackage); } private final String configFile; private final String sourcePackage; private final String dynamicMetricsClassPackage; private final String dynamicMetricsBuilderClassPackage; private final String dynamicDispatcherClassPackage; } ``` ```java public class OfficialOALDefine extends OALDefine { public static final OfficialOALDefine INSTANCE = new OfficialOALDefine(); private OfficialOALDefine() { super( "official_analysis.oal", "org.apache.skywalking.oap.server.core.source.", "org.apache.skywalking.oal.rt.official.metrics.", "org.apache.skywalking.oal.rt.official.metrics.builder.", "org.apache.skywalking.oal.rt.official.dispatcher." ); } } ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
