wu-sheng commented on a change in pull request #25: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/25#discussion_r428980331
########## File path: language-agent/Meter.proto ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +syntax = "proto3"; + +option java_multiple_files = true; +option java_package = "org.apache.skywalking.apm.network.language.agent.v3"; + +import "common/Common.proto"; + +service MeterReportService { + rpc collect (stream MeterData) returns (Commands) { + } +} + +// Label in the meter +message Label { + string name = 1; + string value = 2; +} + +// Work for histogram, defined the bucket +message MeterBucketValue { + int32 bucket = 1; Review comment: I updated the comments based on our offline discussion. Take a look. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
