kezhenxu94 commented on a change in pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#discussion_r432929353
##########
File path:
oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/mysql/MySQLTableInstaller.java
##########
@@ -74,22 +74,22 @@ protected void createTableIndexes(JDBCHikariCPClient client,
if (!modelColumn.isStorageOnly()) {
SQLBuilder tableIndexSQL = new SQLBuilder("CREATE INDEX ");
tableIndexSQL.append(model.getName().toUpperCase())
- .append("_")
- .append(String.valueOf(indexSeq++))
- .append("_IDX ");
+ .append("_")
+ .append(String.valueOf(indexSeq++))
+ .append("_IDX ");
tableIndexSQL.append("ON ").append(model.getName()).append("(")
-
.append(modelColumn.getColumnName().getStorageName())
- .append(")");
+ .append(modelColumn.getColumnName().getStorageName())
+ .append(")");
Review comment:
> I don't know why, but the CI doesn't report in both ways.
CI never reports this kind of styles, we have many existed codes that don't
follow the styles yet, just wanted to remind that the settings may be lost in
your local machine,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
