wu-sheng commented on pull request #4840: URL: https://github.com/apache/skywalking/pull/4840#issuecomment-636564044
> Apologies for the constant changes. I believe this PR to offer the most thorough support and I wanted to make sure to get better Vert.x support in SkyWalking 8.0.0. When I saw the previous PR couldn't support 3.9.1, I rushed it through because I saw there were bigger changes that I needed to make and I wasn't sure how quickly I could make them. It should be fine to change the plugin, basically, that is why we design the agent-based plugin system. Users wouldn't feel these changes happened, because they never really use the APIs, and even our changes have some issues, they could remove or rollback easily by themselves. BTW, I noticed, there is no UT for the new interception, but if those have been covered by the plugin integration test, it should be fine. Let's what coverage result says. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
