kezhenxu94 commented on a change in pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#discussion_r433043929
##########
File path:
test/e2e/e2e-test/src/test/java/org/apache/skywalking/e2e/storage/StorageE2E.java
##########
@@ -156,6 +167,54 @@ void serviceInstanceTopo() throws Exception {
verifyServiceInstanceRelationMetrics(topology.getCalls());
}
+ @RetryableTest
+ void addUITemplate() throws Exception {
+ try {
+ TemplateChangeStatus templateChangeStatus = graphql.addTemplate(
+ new DashboardSetting()
+ .name("test-ui-config-1")
+ .active(true)
+ .configuration("{}")
+ .type(TemplateType.DASHBOARD)
+ );
+ LOGGER.info("add template = {}", templateChangeStatus);
+ } catch (Exception e) {
+ LOGGER.error("add ui template error.", e);
+ }
+ verifyTemplates("expected/storage/dashboardConfiguration.yml");
+ }
+
+ @RetryableTest
+ void changeTemplate() throws Exception {
Review comment:
Seems this case depends on `addUITemplate`, it's a bad idea that one
test case depends on another, please add an individual template in this case
for testing modification (`changeTemplate`), BTW, I'm wondering whether
`updateTemplate` in the backend query plugin is better or not, `update` is more
widely used in the `CRUD` operations @wu-sheng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
