wu-sheng commented on a change in pull request #5:
URL: https://github.com/apache/skywalking-docker/pull/5#discussion_r433129163
##########
File path: 7/7.0/oap-es7/README.md
##########
@@ -20,7 +20,7 @@ $ docker run --name oap --restart always -d
apache/skywalking-oap-server:7.0.0-e
## Start a `standlone` container with `elasticsearch` storage whose address is
`elasticsearch:9200`
```
-$ docker run --name oap --restart always -d -e SW_STORAGE=elasticsearch -e
SW_STORAGE_ES_CLUSTER_NODES=elasticsearch:9200
apache/skywalking-oap-server:7.0.0-es7
+$ docker run --name oap --restart always -d -e ES_VERSION=es7 -e
SW_STORAGE_ES_CLUSTER_NODES=elasticsearch:9200
apache/skywalking-oap-server:7.0.0-es7
Review comment:
I know the existing doc is not correct, but your change is not correct
too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
