wu-sheng edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-640316221
> and writing expectedData.yaml requires skills. Any test requires skills and time. And the point is, we could run them automatically and tested in future changes. In the OSS, we can't afford to run thousands of tests every time when we try to merge or release something. The great and stability you are feeling are 200+ contributors use their time to work on automatic tests. I have to ask you to add this. This thing is required for all agent side changes. This one is not hard, you just need to copy one case from Spring(bootstrap classloader) and another from Tomcat(container classloader), open the config, active the Arthas(or some tools you feel important to test) and make sure the cases passed. Expected data files are there, we don't require you to create cases, but you should test the things you mentioned and fixed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
