wu-sheng commented on a change in pull request #4894:
URL: https://github.com/apache/skywalking/pull/4894#discussion_r437953008
##########
File path: apm-sniffer/apm-sdk-plugin/pom.xml
##########
@@ -47,6 +47,7 @@
<module>sharding-sphere-3.x-plugin</module>
<module>sharding-sphere-4.x-plugin</module>
<module>sharding-sphere-4.x-RC3-plugin</module>
+ <module>sharding-sphere-4.1.0-plugin</module>
Review comment:
Skywalking doesn't need the different plugin jars to identify the
versions, your plugin instrumentation witness definition makes that. So, once
you moved the codes into one plugin, you could use separate packages for
different versions. Others wouldn't be loaded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
